Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[confidentialledger] Fix: use asyncio.run instead of loop variable #26098

Merged
merged 1 commit into from
Oct 7, 2022
Merged

[confidentialledger] Fix: use asyncio.run instead of loop variable #26098

merged 1 commit into from
Oct 7, 2022
+6 −12

Conversation

kyc5644
Copy link
Contributor

@kyc5644 kyc5644 commented Sep 8, 2022

Co-authored-by: wonhyeongseo wonhseo@kakao.com

Description

Fix #21207

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

Fix: use asyncio.run instead of loop variable
fbdcd14 
Co-authored-by: wonhyeongseo <wonhseo@kakao.com>
@kyc5644 kyc5644 requested a review from lmazuel as a code owner September 8, 2022 14:50
@ghost ghost added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Sep 8, 2022
@ghost
Copy link

ghost commented Sep 8, 2022

Thank you for your contribution kyc5644! We will review the pull request and get back to you soon.

@ghost
Copy link

ghost commented Sep 8, 2022

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

❌ kyc5644 sign now
You have signed the CLA already but the status is still pending? Let us recheck it.

@kyc5644 kyc5644 changed the title Fix: use asyncio.run instead of loop variable [confidentialledger] Fix: use asyncio.run instead of loop variable Sep 8, 2022
@kristapratico
Copy link
Member

/azp run python - confidentialledger - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

kristapratico
kristapratico approved these changes Sep 13, 2022
View reviewed changes
Copy link
Member

@kristapratico kristapratico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @kyc5644 thanks for your contribution! Would you mind signing the CLA so we can help get this merged? Thanks!

#26098 (comment)

@xiangyan99 xiangyan99 merged commit 937adc1 into Azure:main Oct 7, 2022
inirudebwoy pushed a commit to inirudebwoy/azure-sdk-for-python that referenced this pull request Oct 10, 2022
@kyc5644 @inirudebwoy
Fix: use asyncio.run instead of loop variable (Azure#26098)
44b9e1f 
Co-authored-by: wonhyeongseo <wonhseo@kakao.com>

Co-authored-by: kyc5644 <kyc5644>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmazuel lmazuel lmazuel approved these changes

@kristapratico kristapratico kristapratico approved these changes

Assignees
No one assigned
Labels
customer-reported Issues that are reported by GitHub users external to the Azure organization.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update async samples to use asyncio.run instead of loop
4 participants
@kyc5644 @kristapratico @lmazuel @xiangyan99